refactor(tool-registry): yield Config/Plugin services, use Effect.forEach#19363
Merged
kitlangton merged 1 commit intodevfrom Mar 27, 2026
Merged
refactor(tool-registry): yield Config/Plugin services, use Effect.forEach#19363kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
kitlangton
force-pushed
the
effect/tool-registry-native
branch
2 times, most recently
from
b3aa424 to
4250c77
Compare
… Effect.forEach - Yield Config.Service and Plugin.Service instead of calling facades - Convert state init from Effect.promise wrapper to direct Effect calls - Convert all() from async function to Effect.fn - Convert tools() Promise.all to Effect.forEach with unbounded concurrency - Export Plugin.defaultLayer - Add explicit return type on tools() facade to fix circular type inference with BatchTool
kitlangton
force-pushed
the
effect/tool-registry-native
branch
from
4250c77 to
6eeb175
Compare
opencode-agent bot
added a commit
that referenced
this pull request
Mar 27, 2026
…s, use Effect.forEach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config.ServiceandPlugin.Servicedirectly instead of calling async facadesEffect.promisewrapper to direct Effect service callsall()from async function toEffect.fntools()fromPromise.all+ facade calls toEffect.forEachwithplugin.triggerPlugin.defaultLayer(was private)tools()facade to fix circular type inference withBatchToolOnly remaining
Effect.promiseistool.init({ agent })— each tool defines its own async init callback, converting those would require changing the Tool interface.Test plan
bun run typecheckpasses