feat(acp): move reasoning level to a separate switcher#19345
Open
oskarraszkiewicz wants to merge 1 commit intoanomalyco:devfrom
Open
feat(acp): move reasoning level to a separate switcher#19345oskarraszkiewicz wants to merge 1 commit intoanomalyco:devfrom
oskarraszkiewicz wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16543
Type of change
What does this PR do?
This PR moves the reasoning level/model variants to a separate switcher, so the model selector is easier to use in IDEs which use ACP (Zed, JetBrains, neovim, etc.). Currently, every model variants appears as a separate model, which results in hard to use switcher. GPT-5.4 is 6 separate models right now.
After the change, it's just one model with a separate switcher.
I based the changes on how zed-industries/codex-acp handles it.
How did you verify your code works?
I tested the changes by adding a custom ACP in Zed 0.229.0 (macOS 26.4, brew install). I checked it on an actual codebase and compared the
none,defaultandxhighvariants to compare how they work. It clearly has a different reasoning budget.Also, I wrote test cases for it.
Didn't test in other editors.
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
(before)
(after)
Checklist
If you do not follow this template your PR will be automatically rejected.