fix(task): ignore invalid task_id when spawning subagents#19328
Open
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Open
fix(task): ignore invalid task_id when spawning subagents#19328Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Haohao-end wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #19239
Type of change
What does this PR do?
The
tasktool tried to resume an existing subagent session by callingSession.get(SessionID.make(params.task_id)).catch(...).That was not safe for malformed
task_idvalues. Iftask_idwas not a valid session id, the validation path could fail before the fallback logic had a chance to run, so the subagent would not continue and no fresh session would be created.This change validates
task_idfirst withSessionID.zod.safeParse(...). If the id is valid, the tool still tries to reuse the existing session. If the id is invalid, it skips reuse and falls back to creating a fresh subagent session.I also added regression coverage for both paths:
task_idfalls back to a new sessiontask_idstill reuses the existing sessionHow did you verify your code works?
bun test test/tool/task.test.ts --timeout 30000bun turbo typecheckScreenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist