Skip to content

fix(app): solidify workspace tests + drag & drop functionality & reordering#19303

Draft
neriousy wants to merge 4 commits intoanomalyco:devfrom
neriousy:fix/solidify-workspace-test
Draft

fix(app): solidify workspace tests + drag & drop functionality & reordering#19303
neriousy wants to merge 4 commits intoanomalyco:devfrom
neriousy:fix/solidify-workspace-test

Conversation

@neriousy
Copy link
Copy Markdown
Contributor

@neriousy neriousy commented Mar 26, 2026

Issue for this PR

Closes #67

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Workspace-test was flaky, this pr solidifies it
Workspace drag & drop functionality was jumpy / not properly following the cursor

Fixes this error which was happening when running e2e test

[chromium] › e2e/projects/workspaces.spec.ts:254:1 › can delete a workspace
[e2e:pageerror] TypeError: 'get' on proxy: property 'Symbol(solid-proxy)' is a read-only and non-configurable data property on the proxy target but the proxy did not return its actual value (expected '[object Array]' but got '[object Array]')
    at isWrappable (http://127.0.0.1:3000/node_modules/.vite/deps/chunk-N72VEKS2.js?v=b739287e:41:56)
    at http://127.0.0.1:3000/node_modules/.vite/deps/chunk-N72VEKS2.js?v=b739287e:430:9
    at http://127.0.0.1:3000/node_modules/.vite/deps/chunk-N72VEKS2.js?v=b739287e:435:7
    at updatePath (http://127.0.0.1:3000/node_modules/.vite/deps/chunk-N72VEKS2.js?v=b739287e:205:13)
    at http://127.0.0.1:3000/node_modules/.vite/deps/chunk-N72VEKS2.js?v=b739287e:225:77
    at runUpdates (http://127.0.0.1:3000/node_modules/.vite/deps/chunk-EZWYHVNM.js?v=b739287e:845:17)
    at batch (http://127.0.0.1:3000/node_modules/.vite/deps/chunk-EZWYHVNM.js?v=b739287e:454:10)
    at setStore (http://127.0.0.1:3000/node_modules/.vite/deps/chunk-N72VEKS2.js?v=b739287e:224:5)
    at setProjects (http://127.0.0.1:3000/src/context/global-sync.tsx?t=1774534252793:66:7)
    at Object.set (http://127.0.0.1:3000/src/context/global-sync.tsx?t=1774534252793:82:7

Overall the workspace test follows @Hona's earlier pattern when solidifying tests

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

Run tests
Drag & drop workspaces - local should not be moved

Screenshots / recordings

2026-03-26.16-19-16.mp4

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@neriousy neriousy marked this pull request as ready for review March 26, 2026 14:58
@neriousy neriousy requested a review from adamdotdevin as a code owner March 26, 2026 14:58
@github-actions github-actions bot added contributor needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@neriousy neriousy marked this pull request as draft March 26, 2026 15:23
@neriousy neriousy marked this pull request as ready for review March 26, 2026 15:28
@neriousy neriousy marked this pull request as draft March 26, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] how to use typescript-go lsp

1 participant