docs(studio): cite the tracking issue in the giant-component suppressions - #231
docs(studio): cite the tracking issue in the giant-component suppressions#231prisis wants to merge 1 commit into
Conversation
…ions The ten `no-giant-component` suppressions claimed the debt was "tracked" — first as "tracked separately" (nothing tracked it), then as recorded in plans/README.md (an entry that was never written). Both were the same failure: a justification whose load-bearing half was not true. #230 now tracks it for real — all ten with line counts, a suggested order starting with the four pure helpers that would drop use-data-browser.tsx under the threshold, and a definition of done. Each suppression cites it by number and states its own exact line count; the Wave 15 notes record the deferral. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
WalkthroughUpdated ten ChangesGiant component tracking annotations
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for following the naming conventions! 🙏 |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
|
Superseded — decomposing the components outright, which deletes these suppressions rather than annotating them. Tracking issue #230 stays as the record until that lands. |
Merging this PR will degrade performance by 4.28%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | flat 3 primitives (the notify.send attribute shape) |
55.7 µs | 62.6 µs | -11.04% |
| ❌ | count, no attributes |
57.7 µs | 64.9 µs | -11.01% |
| ⚡ | baseline (Object.keys + toInternal + path spread per field) |
71.9 µs | 64.9 µs | +10.78% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix/studio-giant-component-tracking (75fce36) with alpha (187b10a)2
Footnotes
-
2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
alpha(3eedcd1) during the generation of this report, so 187b10a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
1 participant
Follow-up to the react-doctor sweep in #229, closing the one finding from the thermo review that could not be fixed in code.
The ten
react-doctor/no-giant-componentsuppressions justified themselves with a claim that was not true. First they said the debt was "tracked separately" — nothing tracked it. The replacement said it was recorded under "Deferred" inplans/README.md— an entry that was never actually written. Same failure twice: the load-bearing half of the justification was fiction, which turns real debt into invisible debt.#230 now tracks it properly: all ten components with their line counts, a suggested order, and a definition of done ("the suppression can be deleted and the scan still reports zero"). Each suppression cites the issue by number and carries its own exact line count. The Wave 15 notes in
plans/README.mdrecord the deferral so the plan history and the code agree.The suggested first step in #230 is the cheap one the sweep already set up:
use-data-browser.tsx's four hoisted helpers (toPageArgs,toCountArgs,resolveStagedChanges,editableColumn) are pure and hook-free, so moving them to a sibling module drops that file under the threshold at zero behavioural cost.Comments only — no code paths change. ESLint
--max-warnings=0,tsc --noEmit, 930 studio tests, Prettier, andreact-doctor(0 findings) all clean.🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Maintenance