Skip to content

feat: allow increasing page_size for device query #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shurick2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow increasing page_size for device query #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion annet/adapters/netbox/v37/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
import ssl

from adaptix import P
Expand All @@ -9,6 +10,8 @@
from annet.storage import Storage
from .models import IpAddressV37, NetboxDeviceV37, InterfaceV37, PrefixV37

interfaces_page_size = int(os.getenv("NETBOX_INTERFACES_PAGE_SIZE", 100))
Copy link
Contributor

@Tishka17 Tishka17 May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should move this logic to NetboxStorageOpts



class NetboxV37Adapter(NetboxAdapter[NetboxDeviceV37, InterfaceV37, IpAddressV37, PrefixV37]):
def __init__(
Expand Down Expand Up @@ -68,7 +71,7 @@ def get_device(self, device_id: int) -> NetboxDeviceV37:
return self.convert_device(self.netbox.dcim_device(device_id))

def list_interfaces_by_devices(self, device_ids: list[int]) -> list[InterfaceV37]:
return self.convert_interfaces(self.netbox.dcim_all_interfaces(device_id=device_ids).results)
return self.convert_interfaces(self.netbox.dcim_all_interfaces(device_id=device_ids, page_size=interfaces_page_size).results)

def list_interfaces(self, ids: list[int]) -> list[InterfaceV37]:
return self.convert_interfaces(self.netbox.dcim_all_interfaces(id=ids).results)
Expand Down