Skip to content

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Dec 7, 2025

Important

Save this for 2.23.1

It's likely that there's another cause other than the backup manager

How Has This Been Tested?

⚠️ it's not

I don't know if this will be useful, Timber likely wasn't initialized. Maybe crash reporting won't work (?)

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added this to the 2.23.1 release milestone Dec 7, 2025
@david-allison david-allison added Review High Priority Request for high priority review Blocked by dependency Currently blocked by some other dependent / related change labels Dec 7, 2025
It's likely that there's another cause other than the backup manager

Diagnostics for issue 19050
@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Dec 8, 2025
@david-allison david-allison added Queued for Cherry Pick to Stable Branch and removed Blocked by dependency Currently blocked by some other dependent / related change labels Dec 10, 2025
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like any harm could come of it, let's go

@mikehardy mikehardy added this pull request to the merge queue Dec 10, 2025
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Dec 10, 2025
Merged via the queue into ankidroid:main with commit e856946 Dec 10, 2025
15 checks passed
@github-actions github-actions bot modified the milestones: 2.23.1 release, 2.23 release Dec 10, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Dec 10, 2025
@david-allison david-allison deleted the debug-19050 branch December 10, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants