Skip to content

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

  • API 36 Tablet emulator: Deck Picker opens and seems fine

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Priority-Low Needs Review Next version Changes to be merged in the next version, to keep the current release stable. labels Dec 7, 2025
@david-allison david-allison mentioned this pull request Dec 7, 2025
94 tasks
holder.deckLayout.setOnClickListener { onDeckSelected(node.did) }
holder.deckLayout.setOnLongClickListener {
holder.binding.deckLayout.setOnClickListener { onDeckSelected(node.did) }
holder.binding.deckLayout.setOnLongClickListener {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick: not consistent, there are several lines in this method were holder.binding is used while most places use binding directly.

@lukstbit lukstbit added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Dec 20, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Dec 20, 2025
@david-allison david-allison added this pull request to the merge queue Dec 20, 2025
Merged via the queue into ankidroid:main with commit 64e5a83 Dec 20, 2025
18 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Dec 20, 2025
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Dec 20, 2025
@david-allison david-allison deleted the vb-DeckAdapter.ViewHolder branch December 20, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Next version Changes to be merged in the next version, to keep the current release stable. Priority-Low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants