feat: Allow card options in notes mode

[xenonnn4w]

Purpose / Description

Card Browser previously blocked reposition, set due date, and reset progress operations in notes mode with an error message. Desktop Anki allows these operations via the Cards submenu.

Fixes

• Fixes Allow Options to be Used in Notes Mode #18307

Approach

Removed warnUserIfInNotesOnlyMode() blocking method from CardBrowser.kt and its checks from three operations in CardBrowserFragment.kt:

• rescheduleSelectedCards()
• repositionSelectedCards()
• onResetProgress()

Added verification logging for data integrity. The existing queryAllSelectedCardIds() already handles both modes correctly ; querying all card IDs for selected notes when in notes mode.

How Has This Been Tested?

By unit tests and manual testing ;

Added 2 tests in CardBrowserViewModelTest.kt:

• reposition in notes mode affects all cards 18307 - Verifies repositioning affects all cards of selected notes
• reset progress in notes mode affects all cards 18307 - Verifies reset affects all cards of selected notes

Run: ./gradlew :AnkiDroid:testPlayDebugUnitTest --tests "*18307"

Both tests will pass.

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

Tests are excellent, thank you!

Minor nitpick on removing the comment - not necessary if you're happy you tested it

---

Link the cause of this warning, so people can understand how the feature came to be (likely in the commit message):

• #15509

---

Could you add justification for why this works now, but was inconclusive/broken at the time

For example:

• #17962 fixed reposition

[david-allison]

This doesn't seem to address:

Could you add justification for why this works now, but was inconclusive/broken at the time

For example:

• Enable feature complete repositioning of new cards #17962 fixed reposition

[xenonnn4w]

ah my bad i was on the airport just got some time there so i resolved the comments; missed the original message. Updated the commit message now!

[david-allison]

That's the PR where the restrictions were added, not justification for why they can be removed.

I want this in, so, could you add this to the commit message:

• Reschedule: d847d91 (issue 15699)
• Reposition: 4db4dfb (issue 17962)
• Reset: e3fa840 (issue 17176)

---

I want to block this from merging on getting the commit message/documentation of the change correct

But, the code is correct. Needs Second Approval Has one approval, one more approval to merge so this can move on, and Needs Author Reply Waiting for a reply from the original author before this is merged

[david-allison]

With link previews

• Reschedule: feat: "set due date" #15699: d847d91
• Reposition: Enable feature complete repositioning of new cards #17962 4db4dfb
• Reset: Refactor ForgetCardsDialog and potentially fix a bug #17176 e3fa840