refactor: delete ReminderService

GSoC 2025: Review Reminders

- ReminderService was an old attempt at implementing review reminders, but the main methods inside are never actually called anymore. The only code that was still referencing the class was only accessing a constant in its companion object. Here, I've moved that constant out into IntentHandler (where it was previously used) and deleted ReminderService and its test.
- I've decided to fully delete the class instead of only marking it as ready for deprecation because the code is never actually run.
- Deleted unused strings, too.

Author: ericli3690

AnkiDroid/src/main/AndroidManifest.xml

@@ -624,11 +624,6 @@
             android:enabled="true"
             android:exported="false"
             />
-        <receiver
-            android:name=".services.ReminderService"
-            android:enabled="true"
-            android:exported="false"
-            />
         <receiver
             android:name=".services.BootService"
             android:enabled="true"

AnkiDroid/src/main/java/com/ichi2/anki/IntentHandler.kt

@@ -35,7 +35,6 @@ import com.ichi2.anki.dialogs.requireDeckPickerOrShowError
 import com.ichi2.anki.libanki.DeckId
 import com.ichi2.anki.noteeditor.NoteEditorLauncher
 import com.ichi2.anki.servicelayer.ScopedStorageService
-import com.ichi2.anki.services.ReminderService
 import com.ichi2.anki.settings.Prefs
 import com.ichi2.anki.ui.windows.reviewer.ReviewerFragment
 import com.ichi2.anki.utils.MimeTypeUtils
@@ -162,7 +161,7 @@ class IntentHandler : AbstractIntentHandler() {
         reloadIntent: Intent,
         reviewerIntent: Intent,
     ) {
-        val deckId = intent.getLongExtra(ReminderService.EXTRA_DECK_ID, 0)
+        val deckId = intent.getLongExtra(REVIEW_DECK_INTENT_EXTRA_DECK_ID, 0)
         Timber.i("Handling intent to review deck '%d'", deckId)
 
         val reviewIntent =
@@ -336,6 +335,7 @@ class IntentHandler : AbstractIntentHandler() {
     }
 
     companion object {
+        const val REVIEW_DECK_INTENT_EXTRA_DECK_ID = "EXTRA_DECK_ID"
         private const val CLIPBOARD_INTENT = "com.ichi2.anki.COPY_DEBUG_INFO"
         private const val CLIPBOARD_INTENT_EXTRA_DATA = "clip_data"
 
@@ -383,7 +383,7 @@ class IntentHandler : AbstractIntentHandler() {
                 }
             } else if ("com.ichi2.anki.DO_SYNC" == action) {
                 LaunchType.SYNC
-            } else if (intent.hasExtra(ReminderService.EXTRA_DECK_ID)) {
+            } else if (intent.hasExtra(REVIEW_DECK_INTENT_EXTRA_DECK_ID)) {
                 LaunchType.REVIEW
             } else if (action == CLIPBOARD_INTENT) {
                 LaunchType.COPY_DEBUG_INFO
@@ -472,6 +472,17 @@ class IntentHandler : AbstractIntentHandler() {
             }
         }
 
+        /**
+         * Returns an intent to review a specific deck.
+         *
+         * @param context
+         * @param deckId the deck ID of the deck to review
+         */
+        fun getReviewDeckIntent(
+            context: Context,
+            deckId: DeckId,
+        ): Intent = Intent(context, IntentHandler::class.java).putExtra(REVIEW_DECK_INTENT_EXTRA_DECK_ID, deckId)
+
         /**
          * Returns an intent to review a specific deck.
          * This does not states which reviewer to use, instead IntentHandler will choose whether to use the
@@ -483,7 +494,7 @@ class IntentHandler : AbstractIntentHandler() {
             deckId: DeckId,
         ) = Intent(context, IntentHandler::class.java).apply {
             setAction(Intent.ACTION_VIEW)
-            putExtra(ReminderService.EXTRA_DECK_ID, deckId)
+            putExtra(REVIEW_DECK_INTENT_EXTRA_DECK_ID, deckId)
         }
     }
 }

AnkiDroid/src/main/java/com/ichi2/anki/services/ReminderService.kt

@@ -169,11 +169,6 @@
     <string name="tag_editor_add_feedback_existing">Existing tag “%1$s” selected</string>
     <!-- Time spans -->
 
-    <string name="reminder_title">Do not forget to study today!</string>
-    <plurals name="reminder_text">
-        <item quantity="one">%2$d card to review in %1$s</item>
-        <item quantity="other">%2$d cards to review in %1$s</item>
-    </plurals>
     <!-- Currently only used if exporting APKG fails -->
     <string name="apk_share_error">Error sharing apkg file</string>
     <!-- Import and export v2 feedback -->

AnkiDroid/src/main/res/values/02-strings.xml

@@ -20,8 +20,8 @@ import android.content.Intent
 import androidx.core.net.toUri
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import com.ichi2.anki.IntentHandler.Companion.getLaunchType
+import com.ichi2.anki.IntentHandler.Companion.getReviewDeckIntent
 import com.ichi2.anki.IntentHandler.LaunchType
-import com.ichi2.anki.services.ReminderService.Companion.getReviewDeckIntent
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.equalTo
 import org.junit.Test

AnkiDroid/src/test/java/com/ichi2/anki/IntentHandlerTest.kt

@@ -29,6 +29,7 @@ import com.ichi2.anki.DrawingActivity
 import com.ichi2.anki.FilteredDeckOptions
 import com.ichi2.anki.Info
 import com.ichi2.anki.IntentHandler
+import com.ichi2.anki.IntentHandler.Companion.getReviewDeckIntent
 import com.ichi2.anki.IntentHandler2
 import com.ichi2.anki.IntroductionActivity
 import com.ichi2.anki.LoginActivity
@@ -44,7 +45,6 @@ import com.ichi2.anki.multimedia.MultimediaActivity
 import com.ichi2.anki.notetype.ManageNotetypes
 import com.ichi2.anki.preferences.PreferencesActivity
 import com.ichi2.anki.previewer.CardViewerActivity
-import com.ichi2.anki.services.ReminderService.Companion.getReviewDeckIntent
 import com.ichi2.anki.ui.windows.managespace.ManageSpaceActivity
 import com.ichi2.anki.ui.windows.permissions.PermissionsActivity
 import com.ichi2.testutils.ActivityList.ActivityLaunchParam.Companion.get