Skip to content

Add file size columns to download status table (#249) #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
+133 −13
Open

Add file size columns to download status table (#249) #272

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
061d8dc
Add test for download status table size columns
ANAMASGARD Oct 29, 2025
0316abd
Now using grep() and expect_gt() for informative test failures
ANAMASGARD Oct 29, 2025
038edd1
Added the download size info to status table
ANAMASGARD Oct 30, 2025
a1721ff
Merge branch 'master' into add-download-size-info
ANAMASGARD Oct 31, 2025
1c016bc
Calculate chunk sizes in R, display in download table
ANAMASGARD Oct 31, 2025
5d33585
Bump version to 2025.10.31 and add NEWS entry for PR#272
ANAMASGARD Oct 31, 2025
5419abf
Merge branch 'master' into add-download-size-info
ANAMASGARD Oct 31, 2025
d5e661d
Use spaces in column headers: 'total MB' and 'mean MB'
ANAMASGARD Oct 31, 2025
bf360fa
Add download size info to status table (#249)
ANAMASGARD Oct 31, 2025
073d7b7
Merge branch 'master' into add-download-size-info
ANAMASGARD Nov 9, 2025
81cd1e1
Fix MB calculation inconsistency in download table
ANAMASGARD Nov 10, 2025
db9139b
Update download table tests for new files column
ANAMASGARD Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions inst/htmljs/animint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,9 @@ var animint = function (to_select, json_file) {
g_info.tr.append("td").attr("class", "chunk");
g_info.tr.append("td").attr("class", "downloaded").text(0);
g_info.tr.append("td").text(g_info.total);
g_info.tr.append("td").attr("class", "total_MB").text("0.00");
g_info.tr.append("td").attr("class", "mean_MB").text("0.00");
g_info.tr.append("td").attr("class", "rows").text("0");
g_info.tr.append("td").attr("class", "status").text("initialized");

// load chunk tsv
Expand Down Expand Up @@ -1008,6 +1011,37 @@ var animint = function (to_select, json_file) {
// data, and then calling draw_geom to actually draw it.
var draw_geom = function(g_info, chunk, selector_name, PANEL){
g_info.tr.select("td.status").text("displayed");

// Calculate sizes for this geom
var total_bytes = 0;
var total_rows = 0;
var chunk_count = 0;
for(var chunk_id in g_info.data){
var chunk_data = g_info.data[chunk_id];
if(chunk_data){
if(Array.isArray(chunk_data)){
total_rows += chunk_data.length;
var chunk_string = JSON.stringify(chunk_data);
total_bytes += chunk_string.length;
chunk_count++;
}else if(typeof chunk_data === 'object'){
for(var key in chunk_data){
if(Array.isArray(chunk_data[key])){
total_rows += chunk_data[key].length;
}
}
var chunk_string = JSON.stringify(chunk_data);
total_bytes += chunk_string.length;
chunk_count++;
}
}
}
var total_MB = (total_bytes / 1048576).toFixed(2);
var mean_MB = chunk_count > 0 ? (total_bytes / chunk_count / 1048576).toFixed(2) : "0.00";
g_info.tr.select("td.total_MB").text(total_MB);
g_info.tr.select("td.mean_MB").text(mean_MB);
g_info.tr.select("td.rows").text(total_rows);

var svg = SVGs[g_info.classed];
// derive the plot name from the geometry name
var g_names = g_info.classed.split("_");
Expand Down Expand Up @@ -2375,6 +2409,9 @@ var animint = function (to_select, json_file) {
tr.append("th").attr("class", "chunk").text("selected chunk");
tr.append("th").attr("class", "downloaded").text("downloaded");
tr.append("th").attr("class", "total").text("total");
tr.append("th").attr("class", "total_MB").text("total_MB");
tr.append("th").attr("class", "mean_MB").text("mean_MB");
tr.append("th").attr("class", "rows").text("rows");
tr.append("th").attr("class", "status").text("status");

// Add geoms and construct nest operators.
Expand Down
6 changes: 6 additions & 0 deletions tests/testthat/test-download-status-table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
test_that("download status table should show file sizes", {
js_file = system.file("htmljs", "animint.js", package="animint2")
js_text = paste(readLines(js_file), collapse=" ")
mb_columns = grep("total_MB", js_text)
expect_gt(length(mb_columns), 0)
})