Combine upload of R and JS coverage #260
Conversation
|
https://app.codecov.io/github/animint/animint2/commit/d4edb31a1006db559fcebcc95197c4b52269f11d says There is an error processing the coverage reports https://github.com/animint/animint2/actions/runs/18722037868/job/53399754297?pr=260 says |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 72.73% 77.37% +4.63%
==========================================
Files 164 164
Lines 8792 9355 +563
Branches 0 562 +562
==========================================
+ Hits 6395 7238 +843
+ Misses 2397 2117 -280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - name: install and update texlive | ||
| run: /usr/bin/sudo DEBIAN_FRONTEND=noninteractive apt update -y -qq | ||
| - run: /usr/bin/sudo DEBIAN_FRONTEND=noninteractive apt install tidy texlive texlive-fonts-extra -y |
There was a problem hiding this comment.
these are only required for CRAN checks, not testing, so please remove.
| runs-on: ubuntu-latest | ||
| name: CRAN checks | ||
| env: | ||
| TEST_SUITE: CRAN |
There was a problem hiding this comment.
would it be better if this job be moved to a separate file?
.github/workflows/tests.yaml
Outdated
| Rscript -e "if (!requireNamespace('covr', quietly=TRUE)) install.packages('covr'); cov <- covr::package_coverage(type='tests', test_files = "tests/testthat.R"); covr::to_cobertura(cov, file='r-coverage.xml')" | ||
| - name: Normalize R coverage paths | ||
| run: | | ||
| if [ -f "r-coverage.xml" ]; then | ||
| perl -0777 -pe "s|<sources>.*?</sources>|<sources><source>.</source></sources>|s" -i r-coverage.xml | ||
| sed -i 's|\\\\|/|g' r-coverage.xml |
There was a problem hiding this comment.
can these two please be combined into a single R script?
instead of perl and sed, I think you want gsub() in R?
tdhock
left a comment
tdhock
left a comment
There was a problem hiding this comment.
thanks very much! Can you please see comments and revise if necessary?
Fixes #254