Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diffApply now returns the original object instead of the last nested node the path walk stopped on.
{a:[1,2,3,4,5]}plus the issue's patch already mutated the root to{a:[1,2,5]}; the return value was[1,2,5]. Returning the original object matches the declared return typeT. In-place mutation is unchanged.An empty patch used to return
undefinedbecausevar subObjectwas never assigned. Empty patches now return the original object too.The change always returns the original root
obj. The alternatives are keeping the last walkedsubObject, or special-casingdiff.length === 0so empty patches still returnundefined. The issue, the types (: T), and the README all treat the root as the subject. Nested-node andundefinedreturns were not a documented contract. Can special-case empty diffs if thatundefinedis load-bearing.Fixes #590