Support narrow p-code stack pointers - #363
Open
zardus wants to merge 1 commit into
Open
Conversation
ArchPcode derived the initial stack pointer with an expression that assumed a stack pointer at least 16 bits wide, so an architecture with a narrower one -- the 8051's stack pointer is a single byte -- raised "ValueError: negative shift count" during construction. Derive the value from the stack pointer's own width instead; it is unchanged for every wider architecture. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 9, 2026
Member
Author
|
THIS MESSAGE WAS GENERATED BY AN AUTOMATED PROCESS Validation record for head
Caveats: |
Member
|
Corpus decompilation diffs can be found at angr/dec-snapshots@master...angr/archinfo_363 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS MESSAGE WAS GENERATED BY AN AUTOMATED PROCESS
ArchPcodederived the initial stack pointer with an expression that assumed a stack pointer at least 16 bits wide, so constructing an architecture with a narrower one — the 8051 and the 8048 have a one-byte stack pointer on a 16-bit address space — raisedValueError: negative shift count.Deriving the value from the stack pointer's own width instead fixes it where the register sizes are read, and leaves every architecture with a wider stack pointer exactly where it was.
The regression constructs
ArchPcode("8051:BE:16:default")and pins the unchanged value for z80, 68000 and x86-64.Validation: #363 (comment)
Related: angr/cle#717, angr/angr#6793.