Open
Conversation
added 14 commits
April 25, 2011 15:13
….. it is intended to be both rails 2.3.x and rails 3.0.x compatible (need tests on rails 2.3.x)
… file, escargot config file (config/elasticsearch.yml) is renamed to config/escargot.yml.
Conflicts: README.markdown
Collaborator
|
hi addame, thanks for the changes, i'm interesting in apply the commit, but it's necesary that changes pass the integrity test in rails 2.3.x and 3.0.x , but i have worked like plugin, can you explain me how run the test like a gem? |
|
I'd like to use escargot on rails 3. Are there any updates to the status of this pull request? |
Author
|
Check this fork .. it's rails 3 compatible ( On Fri, Jun 3, 2011 at 9:22 PM, digitalplaywright <
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Angelf and Jeroig,
I just want to let you know that I have managed to work on escargot and finally made it 3.0.x compatible.
It is interesting to note that the changes have preserved rails 2.3.x compatibility.
There are also a minor change: a generator for the config script is added.
Have a nice day,
Mehdi