refactor(ui): 重构直播任务板块粉丝灯牌管理,引入统一管理dialog#627
Open
FangDingli wants to merge 1 commit into
Open
Conversation
Owner
|
感谢PR。这种改动很多的PR建议先提个issue说一下,如果我觉得行,很多用户也觉得有用再开始动手,不然容易白费力气。 我刚刚简单看了一下:
还有一些细小的问题我就不列举了,比如你写完代码没跑 lint 等等... 想法挺好。用AI写代码没问题,但你得审核ai写出来的东西啊。我个人倾向于关掉这个 PR,因为如果随便看看都能找出这么多问题,背后一定还有隐藏的坑。等你回复。 如果有人想试试这个新UI,我这里构建了一份:bilibili-live-tasks-helper.user.js |
Author
|
确实我的问题,测是测过但是测的不够完全,有两个功能跑通了就完了,提交的有点仓促。你可以先关了我本地继续改一下。 |
Owner
|
我建议你先提个功能issue,详细说说你想做的东西,提供编译好的脚本让大伙用用,收集一下大家意见。 这个PR我就先不关了。你提issue之后我会给你pin一下,要是长时间几乎没人回复或者都不想要你的功能我再把你的PR和issue一起关了。 |
Owner
|
顺便说一下,接下来会做 #626 这个 issue 提到的功能,是会改UI的( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
效果预览:

