feat: first time config+datafile initialization #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- properly fetches data files during both git + local install for `ads-setup` - now creates config on first-time import if it does not exist already - new `ADSConfig.save` method, just dumps as json to given path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ads-setupCLI entrypointADSConfig.savemethod (just dumps as JSON to given path)This adds the least overhead in terms of packages, and it's a little hacky. You can make it snazzier by using the
pydantic-yamlorpydantic-settingsto make the config prettier, but that's your call. You could also add it to theads-setuproutine instead.Also found the data files didn't copy properly on a
git+install. I think they need to be under the actual package (src/python).