Skip to content

Prevent VSyncSampler recreation #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jruesga wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Prevent VSyncSampler recreation #3275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ries/exoplayer/src/main/java/androidx/media3/exoplayer/video/VideoFrameReleaseHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public final class VideoFrameReleaseHelper {

private final Context context;

private boolean vsyncSampleBuilt;
private boolean vsyncSamplerBuilt;
@Nullable private VSyncSampler vsyncSampler;
private boolean started;
@Nullable private Surface surface;
Expand Down Expand Up @@ -127,10 +127,11 @@ public void setChangeFrameRateStrategy(
public void onStarted() {
started = true;
resetAdjustment();
if (!vsyncSampleBuilt) {
if (!vsyncSamplerBuilt) {
vsyncSampler = VSyncSampler.maybeBuildInstance(context);
}
if (vsyncSampler != null) {
vsyncSamplerBuilt = true;
vsyncSampler.register();
}
updateSurfacePlaybackFrameRate(/* forceUpdate= */ false);
Expand Down