Fix configuration cache on local builds

[SimonMarquis]

by applying the OSS Licenses plugin only on CI builds.

Closes #2031

[gemini-code-assist]

Summary of Changes

Hello @SimonMarquis, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a configuration cache issue impacting local builds by modifying how the Google OSS Licenses plugin is applied. It ensures the plugin is only active within CI environments, preventing local build performance degradation and enhancing the developer experience by maintaining a clean configuration cache.

Highlights

• Conditional Plugin Application: The Google OSS Licenses plugin is now applied conditionally, exclusively during Continuous Integration (CI) builds.
• Configuration Cache Fix: This change directly addresses and resolves issues related to the configuration cache on local development builds, improving build performance.
• Plugin Application Relocation: The application of the OSS Licenses plugin has been moved from app/build.gradle.kts to AndroidApplicationConventionPlugin.kt to centralize and control its conditional application.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix configuration cache issues on local builds by conditionally applying the Google OSS Licenses plugin. While the idea is correct, the implementation uses providers.gradleProperty("CI").isPresent, which is incompatible with Gradle's configuration cache and would prevent it from working on local builds. I've provided a detailed comment explaining the issue and suggesting a more robust, cache-friendly alternative using a Gradle init script for CI builds.

[gemini-code-assist]

While this change correctly intends to apply the OSS licenses plugin only on CI, the use of providers.gradleProperty("CI").isPresent is unfortunately not compatible with Gradle's configuration cache.

According to the Gradle documentation, Provider.isPresent() should not be used. The configuration cache engine cannot track the reason for a property's absence, which prevents it from safely reusing a cached configuration. This will likely cause the configuration cache to be disabled on every local build, negating the benefit of this PR.

A more configuration-cache-friendly approach is to move the conditional logic outside of the build script. For example, you could use a separate init script on your CI server to apply the plugin.

1. Remove this conditional logic from AndroidApplicationConventionPlugin.kt.
2. Create an init script, e.g., scripts/ci.gradle.kts:

   // scripts/ci.gradle.kts
   allprojects {
       plugins.withId("com.android.application") {
           apply(plugin = "com.google.android.gms.oss-licenses-plugin")
       }
   }

3. In your CI configuration, apply this script when running Gradle:

   ./gradlew build --init-script scripts/ci.gradle.kts

This approach keeps the main build logic clean and cacheable, while isolating the CI-specific configuration.