Skip to content

Conversation

@Amir-yazdanmanesh
Copy link

What I have done and why

Removed outdated @SuppressLint("ComposableModifierFactory") annotation and associated TODO comment from AppScrollbars.kt.

The ComposableModifierFactory lint rule was removed in Compose 1.6 as the recommendation changed. Since the project now uses Compose Foundation 1.8.0-alpha07, this suppression is no longer needed.

Changes:

  • Removed @SuppressLint("ComposableModifierFactory") annotation
  • Removed TODO comment
  • Removed unused import android.annotation.SuppressLint

The lint was removed in Compose 1.6 and the project now uses 1.8.0.
Remove the @SuppressLint annotation, TODO comment, and unused import.
@gemini-code-assist
Copy link

Summary of Changes

Hello @Amir-yazdanmanesh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code hygiene by removing an outdated lint suppression and its related artifacts. The ComposableModifierFactory lint rule was deprecated in Compose 1.6, making the existing @SuppressLint annotation and its accompanying TODO comment redundant. By removing these, the codebase is made cleaner and more aligned with current Compose best practices, without impacting functionality.

Highlights

  • Lint Suppression Removal: The @SuppressLint("ComposableModifierFactory") annotation has been removed as it is no longer necessary due to the ComposableModifierFactory lint rule being deprecated in Compose 1.6 and the project now using Compose Foundation 1.8.0-alpha07.
  • Code Cleanup: An associated TODO comment, which indicated the future removal of the lint suppression, has also been removed.
  • Unused Import Removal: The unused android.annotation.SuppressLint import statement has been cleaned up from the file.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the outdated @SuppressLint("ComposableModifierFactory") annotation, its associated TODO comment, and the unused import from AppScrollbars.kt. As the description notes, this lint suppression is no longer needed with the updated Compose version. This is a good piece of code hygiene that improves maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant