Skip to content

fix: porting to curl-impersonate v1.0.0 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

gebing
Copy link

@gebing gebing commented May 26, 2025

porting to curl-impersonate v1.0.0, which support chrome 136

@andrewmackrodt
Copy link
Owner

Thanks for the PR. I've enabled github workflow actions for this PR and it looks like the actions will need updating to reflect the changes in the build script. Going from memory, I think certain params used in the script (e.g. explicitly setting --with-zlib and --with-zstd) were required for the macOS static build to actually compile statically rather than rely on dynamic linking, e.g. the libraries provided by homebrew in the github default os image - although that may have changed in version 1.0.0 of libcurl-impersonate, the workflow action should pick up and fail if dynamic linking is detected if it turns out these params are still required to be manually set.

It may take me a few days to merge this PR, until then, the existing release fingerprint for Chrome is the same as Chrome 136, only the user-agent and sec-ch-ua headers differ. It's possible to override the version by passing custom browser options to the impersonate methods, e.g. const curly = impersonate(getChromeConfig({ version: '136' })). Similarly named methods exist for all supported browsers.

@gebing
Copy link
Author

gebing commented May 27, 2025

reverting "--with-zlib" and "--with-zstd”, and now github workflow actions will build success and will fail with unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants