Open
Conversation
this commits upgrade react scripts with all required changes. After this commit we can start using webpack 5.X and then, use wasm natively.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2263c63 to
5119e4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋🏼 I wrote a minimal support for bolt12 offers.
What's going on here
As bolt12 was merged and part of the lightning specs I thought that would be fun to decode offers in this page.
I had few options to do this changes:
Then I thought that BoltzExchange probably had the same dilemma when implementing bolt12 on their webpage. So They solved bringing Offer and Invoice from LDK and building their own wasm.
Said so, I tried using LDK and Boltz one but Webpack version was a bit deprecated. So I went to upgrade react scripts, adding and removing packages so project could use newer webpack (with native support of wasm).
After upgrading, added a bolt12 decoding from the wasm and expose it minimally into the UI.
What to check?
What else could be added?