refactor: extract shared SignUpButton styled component - #249
Open
andrerfneves wants to merge 1 commit into
Open
andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
CommunitySignUpButton (community.js) and ProviderSignUpButton (providers.js) were nearly identical styled components. This extracts the common definition to utils.js as a shared SignUpButton component with optional isDisabled prop support, following the same cleanup pattern established for SectionBase, ImageWrapper, Card, and others.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommunitySignUpButton(incommunity.js) andProviderSignUpButton(inproviders.js) were nearly identical styled components — same color, width, height, padding, border-radius, margin, line-height, background-color, box-shadow, and responsive tablet breakpoint. The provider version also had anisDisabledprop for disabled styling. This extracts them toutils.jsas a sharedSignUpButtoncomponent that includes optionalisDisabledprop support.When
isDisabledis not passed (as in the community section),SignUpButtonbehaves identically to the originalCommunitySignUpButton.This follows the same cleanup pattern established in prior PRs:
SectionBaseImageWrapperCardChanges
utils.jsSignUpButtonstyled component with optionalisDisabledpropcomponents/community.jsSignUpButton; removed localCommunitySignUpButtoncomponents/providers.jsSignUpButton; removed localProviderSignUpButtonTest Plan
npm run build)