Strengthen PII redaction docs and regression tests#25
Merged
Conversation
- Make RunCard fetch the card so semantic-type enrichment runs on the non-parameterized path, matching RunCardWithParams and RunDashboardCard. - Add regression tests covering redaction for structured queries, table data, native saved cards (with and without parameters), dashboard run-card, field values, and the ExportStructuredQuery block. - Expand README PII section with covered commands, semantic-type enrichment behavior, known gaps, export opt-out, and flag/env precedence. Closes #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17.
RunCardfetch the source card so semantic-type enrichment runs on the non-parameterized path, matchingRunCardWithParamsandRunDashboardCard. Native saved questions whose result columns lack a semantic type are now redacted just like the parameterized variants.RunStructuredQueryredactionExportStructuredQueryblocked when redaction is enabledGetTableDataredactionRunCardredaction, including a native-card case where enrichment must fill in missing semantic typesRunCardWithParamsandRunDashboardCardredaction (parameterized paths)GetFieldValuesmatrix: PII field on, non-PII field on, PII field off, plus an assertion that field metadata is only fetched when redaction is onEnrichSemanticTypesdirect tests: fills missing types, picks PII when duplicate names disagree, skips network when all types are presentTest plan
make testmake vetmake build