add sc598 configs for development #6
Conversation
ozan956
force-pushed
the
odurgut
branch
7 times, most recently
from
632ff3e to
bf96cea
Compare
Signed-off-by: Ozan Durgut <[email protected]>
ozan956
force-pushed
the
odurgut
branch
8 times, most recently
from
d694aed to
952b839
Compare
Signed-off-by: Ozan Durgut <[email protected]>
Signed-off-by: Ozan Durgut <[email protected]>
Signed-off-by: Ozan Durgut <[email protected]>
| name: Build ADI br2-external | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
For now I'd just build on pull_request since this is currently a rather slow and resource intensive build. At least until we have seen how it performs with ccache and dl cache
| push: |
| env: | ||
| BR2_DL_DIR: $HOME/.buildroot-dl | ||
| CC: gcc-15 | ||
| CXX: g++-15 |
There was a problem hiding this comment.
The compiler versions shouldn't matter. Note this would just be used for building host tools.
| submodules: recursive | ||
|
|
||
| - name: Prepare Buildroot download dir | ||
| run: mkdir -p "$BR2_DL_DIR" |
There was a problem hiding this comment.
Buildroot won't create this directory?
| key: ${{ runner.os }}-buildroot-dl-${{ hashFiles('configs/**/*.fragment', 'configs/**/*.defconfig') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-buildroot-dl- | ||
|
|
There was a problem hiding this comment.
ccache seems to have been dropped?
br2-external/.github/workflows/build.yml
Lines 35 to 40 in c4ba52c
|
Latest build error: |
| run: | | ||
| cd buildroot | ||
|
|
||
| echo ">>> Selecting defconfig: ${{ matrix.defconfig }}" |
There was a problem hiding this comment.
This shouldn't be necessary since the commands are displayed in the little triangle drop down:
https://github.com/analogdevicesinc/br2-external/actions/runs/19715596206/job/56556778405#step:5:6
|
|
||
| echo ">>> Selecting defconfig: ${{ matrix.defconfig }}" | ||
|
|
||
| make BR2_EXTERNAL="${GITHUB_WORKSPACE}" ${{ matrix.defconfig }} |
There was a problem hiding this comment.
Any reason not to use the normal BR2_EXTERNAL="${PWD}/.."? The above is a bit more magic
| make BR2_EXTERNAL="${GITHUB_WORKSPACE}" ${{ matrix.defconfig }} | ||
|
|
||
| if [ -f "${GITHUB_WORKSPACE}/configs/buildroot.fragment" ] || \ | ||
| [ -f "${GITHUB_WORKSPACE}/configs/debug.fragment" ]; then |
There was a problem hiding this comment.
I wouldn't conditionalize this. If the files don't exist then the build should fail. This adds complexity and room for error.
| [ -f "${GITHUB_WORKSPACE}/configs/debug.fragment" ]; then | ||
| support/kconfig/merge_config.sh .config \ | ||
| "${GITHUB_WORKSPACE}/configs/buildroot.fragment" \ | ||
| "${GITHUB_WORKSPACE}/configs/debug.fragment" |
There was a problem hiding this comment.
As with above, I'd stick with PWD rather than using the Github workflow specific variables. Keep things simple and use the same commands someone would use on their PC.
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: logs-${{ matrix.defconfig }} | ||
| path: buildroot/output/build |
There was a problem hiding this comment.
This isn't just logs, this is the whole build directory. And still missing critical things like the .config. On my local machine this is 12G. This should be removed unless there is a real need that outweighs the resource demand. I manually cancelled this in the latest run after it was running for 17m.
No description provided.