Draft
Conversation
pbthif
reviewed
Oct 28, 2022
| } | ||
| ``` | ||
|
|
||
| ### Service Clients |
Contributor
There was a problem hiding this comment.
I'd like to see some more context about the performance difference of the protocol approach vs the generic approach for service clients. As I understand, existential box redirection is analogous to v-table lookup, which should have a very small perf hit, especially when considering that the underlying operation of the service clients will be a network call.
The generic approach seems much more complex code-wise, especially where there are more than just a couple of service clients, so having more definitive information about why one would go with one approach over the other would be helpful.
pbthif
approved these changes
Oct 28, 2022
ghost
reviewed
Nov 15, 2022
| Applications initialized using `smoke-framework-application-generate` will be created with a stub definition | ||
| of the Context Type- | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Missing swift language specifier for code completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Add discussion on the Context Type, its usage and practices.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.