Skip to content

WIP: Implement mimetic metrics#3

Open
amrueda wants to merge 20 commits intomainfrom
mimetic_metrics
Open

WIP: Implement mimetic metrics#3
amrueda wants to merge 20 commits intomainfrom
mimetic_metrics

Conversation

@amrueda
Copy link
Owner

@amrueda amrueda commented Jul 13, 2023

No description provided.

amrueda added 12 commits July 13, 2023 09:14
…ection for standard metric terms... And test with periodic and Dirichlent BCs
…the p4estMesh FOR CONFORMING STRUCTURED MESHES

-> Single and multi-element cases work
-> The exact Jacobian and mimetic metrics are only implemented for the warped mesh test
-> Since this is a structured mesh, it must be initialized with a single tree in each direction!
-> Uniform refinement works (conforming meshes) but non-conforming meshes do not work yet!
@coveralls
Copy link

coveralls commented Jul 21, 2023

Pull Request Test Coverage Report for Build 5623936772

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 72 of 335 (21.49%) changed or added relevant lines in 7 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.8%) to 95.234%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/meshes/p4est_mesh.jl 30 31 96.77%
src/solvers/dgsem_p4est/containers_3d.jl 35 42 83.33%
examples/p4est_3d_dgsem/elixir_test_mimetic_metrics.jl 0 10 0.0%
examples/structured_3d_dgsem/elixir_advection_free_stream_mimetic_metrics.jl 0 33 0.0%
examples/structured_3d_dgsem/elixir_advection_free_stream_mimetic_metrics_dirichlet.jl 0 33 0.0%
src/solvers/dgsem_structured/containers_3d.jl 6 185 3.24%
Files with Coverage Reduction New Missed Lines %
src/meshes/p4est_mesh.jl 3 99.5%
src/solvers/dgsem_p4est/containers_3d.jl 4 91.79%
src/Trixi.jl 5 40.91%
Totals Coverage Status
Change from base Build 5540190985: -0.8%
Covered Lines: 29836
Relevant Lines: 31329

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants