Skip to content

Improve filter popover usability on mobile #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amrabed merged 1 commit into from
May 25, 2026
Merged

Improve filter popover usability on mobile #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 41 additions & 24 deletions src/components/filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import { ReactNode } from "react";
import { ReactNode, useState } from "react";

import {
AdjustmentsHorizontalIcon,
CheckIcon,
XMarkIcon,
} from "@heroicons/react/24/outline";
import {
Button,
Expand Down Expand Up @@ -105,26 +106,42 @@ export const Filter = ({
}: {
children: ReactNode;
className?: string;
}) => (
<Popover>
<Button
id="filter-trigger"
variant="ghost"
isIconOnly
aria-label="Open filters"
aria-haspopup="dialog"
className={className}
>
<AdjustmentsHorizontalIcon className="size-6" />
</Button>
<Popover.Content
offset={10}
placement="bottom"
className="dark:bg-slate-800 rounded-3xl"
>
<Popover.Dialog className="flex flex-col w-[90vw] max-w-[500px] p-6 gap-8">
{children}
</Popover.Dialog>
</Popover.Content>
</Popover>
);
}) => {
const [isOpen, setIsOpen] = useState(false);

return (
<Popover isOpen={isOpen} onOpenChange={setIsOpen}>
<Popover.Trigger>
<Button
id="filter-trigger"
variant="ghost"
isIconOnly
aria-label="Open filters"
aria-haspopup="dialog"
className={className}
>
<AdjustmentsHorizontalIcon className="size-6" />
</Button>
</Popover.Trigger>
<Popover.Content
offset={10}
placement="top"
className="dark:bg-slate-800 rounded-3xl"
>
<Popover.Dialog className="flex flex-col w-[90vw] max-w-[500px] p-6 gap-8 max-h-[70vh] overflow-y-auto relative">
<Button
variant="ghost"
isIconOnly
size="sm"
onPress={() => setIsOpen(false)}
className="absolute right-4 top-4 text-slate-500 hover:text-slate-900 dark:hover:text-slate-100 min-w-0 h-8 w-8 z-10"
aria-label="Close filters"
>
<XMarkIcon className="size-5" />
</Button>
{children}
</Popover.Dialog>
</Popover.Content>
</Popover>
);
};