Do not provide suggestions inside YAML comments#984
Open
peltevis wants to merge 5 commits intoaml-org:developfrom
Open
Do not provide suggestions inside YAML comments#984peltevis wants to merge 5 commits intoaml-org:developfrom
peltevis wants to merge 5 commits intoaml-org:developfrom
Conversation
BlockLucas
reviewed
Oct 25, 2023
Contributor
There was a problem hiding this comment.
Nostalgic review here 🥺
File deleted by mistake?
Author
There was a problem hiding this comment.
I kept the file but removed all suggestions as this is one of the cases where I don't think ALS should suggest anything as we are inside a comment. The case is:
#%RAML 1.0
title: Sample API
types:
TestType: # *
BlockLucas
approved these changes
Apr 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALS shouldn't provide suggestions inside YAML comments.
Initially I was aiming to fix #894 but I later realized that the problem wasn't that we are not replacing existing text but rather that ALS is providing suggestions inside YAML comments
(P.S @agusayerza here, current repository configuration doesn't let me open an PR from my original account for somereason 🤷)