Skip to content

Added a query to get the absents of month as per #27 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion src/graphql/queries/attendance_queries.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
use std::sync::Arc;

use crate::models::attendance::{Attendance, AttendanceWithMember};
use crate::models::attendance::{AbsentsWithMember, Attendance, AttendanceWithMember};
use async_graphql::{Context, Object, Result};
use chrono::Datelike;
use chrono::NaiveDate;
use sqlx::PgPool;

Expand Down Expand Up @@ -41,4 +42,40 @@ impl AttendanceQueries {

Ok(records)
}

async fn absents_by_month(
&self,
ctx: &Context<'_>,
date: NaiveDate,
) -> Result<Vec<AbsentsWithMember>> {
let pool = ctx.data::<Arc<PgPool>>().expect("Pool must be in context.");

let end_date = date
.with_day(1)
.unwrap()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to use unwraps in the API, makes it harder to debug.

.with_month(date.month() + 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break when the date is in December?

.unwrap();

let records = sqlx::query_as::<_, AbsentsWithMember>(
"SELECT mem.name, mem.year, att.member_id,
COUNT(*) AS absent_days
FROM attendance att
JOIN member mem ON att.member_id = mem.member_id
WHERE
att.is_present = FALSE
AND att.date >= $1
AND att.date < $2
GROUP BY
att.member_id, mem.name, mem.year
ORDER BY
absent_days DESC, mem.name
",
)
.bind(date)
.bind(end_date)
.fetch_all(pool.as_ref())
.await?;

Ok(records)
}
}
8 changes: 8 additions & 0 deletions src/models/attendance.rs
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,11 @@ pub struct AttendanceWithMember {
pub year: i32,
pub group_id: i32,
}

#[derive(SimpleObject, FromRow)]
pub struct AbsentsWithMember {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more appropriate name would be MemberWithAbsence

pub member_id: i32,
pub absent_days: i64,
pub name: String,
pub year: i32,
}
Loading