Skip to content

Bugfix: fix for status in InbandConnectionManager #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
+2 −2
Merged

Bugfix: fix for status in InbandConnectionManager #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nodescraper/pluginexecutor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,6 @@ def run_queue(self) -> list[PluginResult]:
self.logger.exception("Unexpected exception running plugin queue: %s", str(e))
finally:
self.logger.info("Closing connections")
for connection_manager in self.connection_library.values():
connection_manager.disconnect()

if self.plugin_config.result_collators:
self.logger.info("Running result collators")
Expand All @@ -217,6 +215,8 @@ def run_queue(self) -> list[PluginResult]:
],
**collator_args,
)
for connection_manager in self.connection_library.values():
connection_manager.disconnect()

return plugin_results

Expand Down