Chronos-2: Add option to disable DataParallel
#434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulfatir
commented
Dec 15, 2025
shchur
reviewed
Dec 15, 2025
| if disable_data_parallel: | ||
| # This is a hack to disable the default `transformers` behavior of using DataParallel | ||
| training_args._n_gpu = 1 | ||
| assert training_args.n_gpu == 1 # Ensure that the hack worked |
Contributor
There was a problem hiding this comment.
There are some branches where this is set to 0 (e.g. on the CPU)
https://github.com/huggingface/transformers/blob/40dc11cd3eb4126652aa41ef8272525affd4a636/src/transformers/training_args.py#L1778
Are we sure we don't break it? Should we instead set either
training_args._n_gpu = min(1, training_args._n_gpu)or
if disable_data_parallel and torch.cuda.device_count() > 1:
training_args._n_gpu = min(1, training_args._n_gpu)
Contributor
Author
There was a problem hiding this comment.
I added a guard not use_cpu. Do you think is good?
shchur
approved these changes
Dec 15, 2025
| if disable_data_parallel: | ||
| # This is a hack to disable the default `transformers` behavior of using DataParallel | ||
| training_args._n_gpu = 1 | ||
| assert training_args.n_gpu == 1 # Ensure that the hack worked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.