Skip to content

Conversation

@abdulfatir
Copy link
Contributor

Issue #, if available:

Description of changes: This PR improves test coverage by adding unit tests for df_utils. Previously these methods were only being tested as part of Chronos-2 integration tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances test coverage by adding comprehensive unit tests for the df_utils module, which previously was only tested through Chronos-2 integration tests. The tests thoroughly validate data frame validation and conversion functionality with various scenarios including different frequencies, data types, covariates, and error conditions.

Key Changes

  • Added 13 unit tests covering validate_df_inputs and convert_df_input_to_list_of_dicts_input functions
  • Tests validate correct behavior with single/multiple targets, past/future covariates, various frequencies, and error handling
  • Updated .gitignore to exclude Kiro IDE configuration files

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
test/test_df_utils.py Comprehensive unit test suite for df_utils module with 13 test cases covering validation, conversion, dtype casting, error handling, and edge cases
.gitignore Added .kiro directory exclusion for Kiro IDE configuration files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chronos-2-finetuned

# Kiro IDE
.kiro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@abdulfatir abdulfatir enabled auto-merge (squash) December 8, 2025 14:51
@abdulfatir abdulfatir merged commit 086e660 into amazon-science:main Dec 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants