-
Notifications
You must be signed in to change notification settings - Fork 182
lib.data.{Field, Layout, Const}: add __hash__ #1623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1623 +/- ##
==========================================
- Coverage 91.24% 91.23% -0.01%
==========================================
Files 44 44
Lines 11394 11402 +8
Branches 2223 2224 +1
==========================================
+ Hits 10396 10403 +7
Misses 836 836
- Partials 162 163 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also add tests that these types are hashable.
Could you update the changelog? |
Thanks! |
Sorry, didn't notice it was waiting on me still. |
No description provided.