Skip to content

lib.data.{Field, Layout, Const}: add __hash__ #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

rroohhh
Copy link
Contributor

@rroohhh rroohhh commented Jul 31, 2025

No description provided.

@rroohhh rroohhh requested a review from whitequark as a code owner July 31, 2025 08:10
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.23%. Comparing base (5689b6b) to head (bb15bf3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
amaranth/lib/data.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1623      +/-   ##
==========================================
- Coverage   91.24%   91.23%   -0.01%     
==========================================
  Files          44       44              
  Lines       11394    11402       +8     
  Branches     2223     2224       +1     
==========================================
+ Hits        10396    10403       +7     
  Misses        836      836              
- Partials      162      163       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add tests that these types are hashable.

@whitequark
Copy link
Member

Could you update the changelog?

@whitequark
Copy link
Member

Thanks!

@whitequark whitequark disabled auto-merge August 4, 2025 15:27
@whitequark whitequark enabled auto-merge August 4, 2025 15:27
@whitequark whitequark added this pull request to the merge queue Aug 4, 2025
@whitequark
Copy link
Member

Sorry, didn't notice it was waiting on me still.

Merged via the queue into amaranth-lang:main with commit 9b4ad4e Aug 4, 2025
20 of 22 checks passed
@rroohhh rroohhh deleted the const_hash branch August 4, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants