Skip to content

Bugfix: stocks.get_stock_financial_summary raises ValueError and lxml.etree.ParserError #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix: stocks.get_stock_financial_summary raises ValueError and lxml.etree.ParserError #444

wants to merge 2 commits into from

Conversation

@p1ck4rd
Copy link

@p1ck4rd p1ck4rd commented Sep 14, 2021

Hi!
I found several bugs in the stocks.get_stock_financial_summary function:

  • if the table of the requested financial summary contains empty strings in values, ValueError is raised
  • if the /instruments/Financials/changesummaryreporttypeajax endpoint returns an empty body, lxml.etree.ParserError is raised

Here is the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@p1ck4rd