Updated settings navigation in side panel - #894
Conversation
Greptile SummaryThe PR separates Settings into its own sidebar experience and adds searchable, section-based navigation while preserving return navigation to the main app.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4128a35c73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
FluidVoice PR build readyDownload FluidVoice-PR-894-e73e5a6f2d32 The artifact contains the ad-hoc-signed app ZIP, Xcode archive, build manifest, and installation instructions. It expires 5 days after the build. Install the app
This build has its own app identity, so its permissions are separate from the release version of FluidVoice. |
|
@greptileai review again |
3ee058a to
118fd82
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e73e5a6f2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.settingsSidebarView | ||
| .background(self.theme.palette.sidebarBackground) | ||
| .opacity(self.settingsNavigation.isPresented ? 1 : 0) | ||
| .offset(x: self.settingsNavigation.isPresented ? 0 : self.sidebarTransitionDistance) | ||
| .allowsHitTesting(self.settingsNavigation.isPresented) |
There was a problem hiding this comment.
If the user focuses Search Settings and then leaves Settings via Back, the toolbar, or an external navigation request, this subtree is only made transparent and remains mounted, so its NSSearchField can remain the window's first responder. Subsequent typing is then consumed by the invisible search field and can repopulate settingsSearchQuery, causing Settings to reopen with an unexpected filter; explicitly resign or move focus when dismissing Settings.
Useful? React with 👍 / 👎.
1 participant
Description
Type of Change
Related Issue or Discussion
#1
Testing
swiftlint --strict --config .swiftlint.yml Sourcesswiftformat --config .swiftformat SourcesScreenshots / Video
settings.mp4
Notes
Add reviewer context, rollout notes, or known tradeoffs here.