feat(history): add automatic transcription history clearing (#463)#504
Open
devzahirul wants to merge 2 commits into
Open
feat(history): add automatic transcription history clearing (#463)#504devzahirul wants to merge 2 commits into
devzahirul wants to merge 2 commits into
Conversation
…v#463) Adds an 'Automatically Clear History' retention setting with Never, End of Day, After 7 Days, After 30 Days, and After 90 Days options. Expired entries and their saved audio are pruned at store load, before each new entry, at midnight via NSCalendarDayChanged, and immediately (behind a confirmation alert) when the user tightens the interval. Cutoffs are anchored to start-of-day so a retained day never partially expires.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49c4977e9d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Adds historyAutoClearInterval to SettingsBackupPayload as an optional field so restoring a backup preserves the retention policy instead of silently falling back to Never. Older backups without the key decode as nil and leave the current setting untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #463: an Automatically Clear History setting so users who dictate sensitive content don't have to remember to clear transcription history manually.
Options: Never (default, current behavior), End of Day, After 7 Days, After 30 Days, After 90 Days.
Design
The issue proposes scheduled wipes ("cleared daily at midnight"). Since the app can't rely on being awake at a scheduled moment, this is implemented as retention-based pruning — entries older than the selected window are deleted whenever the store gets a chance:
NSCalendarDayChanged(so "End of Day" behaves exactly as the issue describes for long-running sessions),Cutoffs are anchored to
startOfDay, so a retained day never partially expires (e.g. "After 7 Days" keeps 7 full calendar days plus today). Pruned entries also delete their saved dictation audio viaDictationAudioHistoryStore, and the sidebar selection is repaired if the selected entry expires.Safety
Changes
SettingsStore— newHistoryAutoClearIntervalenum (display name, help text,cutoffDate) and persistedhistoryAutoClearIntervalsetting.TranscriptionHistoryStore— newpruneExpiredEntries(); called frominit,addEntry, and a calendar-day-change observer.SettingsView— picker row under the history toggles with the confirmation flow described above.HistoryAutoClearIntervalTestscovering the no-cutoff case, end-of-day boundary (today survives, yesterday expires), start-of-day anchoring for the rolling windows, and raw-value fallback.Testing
swiftlint --strict— 0 violations.xcodebuild build(Fluid scheme) — succeeds.xcodebuild test— full suite green; the 5 new tests pass.Closes #463