Fix deleted modifier-only primary shortcuts staying active#503
Open
Yaomeng1749 wants to merge 4 commits into
Open
Fix deleted modifier-only primary shortcuts staying active#503Yaomeng1749 wants to merge 4 commits into
Yaomeng1749 wants to merge 4 commits into
Conversation
Author
|
Final verification for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #498.
Clears stale Primary Dictation hotkey press state when the primary shortcut list changes. This prevents a deleted modifier-only primary shortcut from keeping a pending hold/tap path active until app restart.
Changes
updatePrimaryShortcuts(_:).Testing
Local:
GitHub Actions, same head
c2caabd26d8c2a50daa6f061e78449aa233d8d5e:Upstream Actions are awaiting maintainer approval for the public-fork workflow.