Conversation
gabrielgazollalbl
approved these changes
Jan 7, 2026
gabrielgazollalbl
left a comment
There was a problem hiding this comment.
in schemas.py:
- maybe it is not clear the difference between
frame_number and shot_num
maybe rename to:
current_frame_number, total_shot_number ?
- Should we have a validation logic for the fields ?
=====
in websockets.py:
Why removing these lines? Not needed for Timepix?
"shot_mean": convert_to_uint8(message.shot_mean.array),
"shot_std": convert_to_uint8(message.shot_std.array),
=====
dylanmcreynolds
commented
Jan 16, 2026
Contributor
Author
dylanmcreynolds
left a comment
There was a problem hiding this comment.
For schemas, I agree. Frames were different from shots when using the Bassler camera. With the timepix, it frame_number doesn't actually mean anything. In a future world the beamline may choose to only use the timepix and we cane remove the frame.
I removed a lot of fields from the websockets.py return package because they are no longer needed in the react UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the timepix "heatmap streaming" zmq listener.
For the time being, we support two modes for the
xps_operator:Wwe will soon probably remove the bassler/heatmap building code from this repo, but not today.
docker-compose.ymlhas been updated to make timepix the defult.This also adds a uv.lock file for development.
This PR does not result in end-to-end processing of timepix. When the timepix code sends a start and stop message, then we will follow up with a PR here to use those to reset counters.