Repository navigation
Conversation
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 24, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 24, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 24, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 24, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954
4 tasks done
eYinka
changed the title
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 27, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 27, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 27, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 27, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 27, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954
matthillco
previously approved these changes
Oct 28, 2025
matthillco
left a comment
matthillco
left a comment
There was a problem hiding this comment.
I've successfully built this docker image against the other PR in Whitehall. No errors and the app spins up fine.
I'm happy to approve this, nice work.
ChrisBAshton
left a comment
ChrisBAshton
left a comment
Contributor
There was a problem hiding this comment.
One comment below 馃檹
| RUN apt-get update -qq && apt-get install -y yarn nodejs | ||
| RUN yarn config set cache-folder /root/.yarn/ | ||
| RUN apt-get update -qq && apt-get install -y nodejs | ||
| RUN corepack enable && yarn set version 4.10.3 |
Contributor
There was a problem hiding this comment.
We generally try to avoid pinning to patch versions - I think I'd replace with this:
Suggested change
| RUN corepack enable && yarn set version 4.10.3 | |
| RUN corepack enable && yarn set version 4.x |
...or is this because it has to match the exact version specified in package.json?
(If they need to be in sync, I'd add an inline comment to that effect, in this Dockerfile ^
Or I wonder if there's something dynamic we can do... something like this (thanks ChatGPT!)...?
# Enable corepack, fetch Yarn version from Whitehall package.json, and install that exact version
RUN corepack enable && \
YARN_VERSION=$(curl -s https://raw.githubusercontent.com/alphagov/whitehall/main/package.json \
| jq -r '.packageManager' \
| sed -E 's/^yarn@//') && \
yarn set version "$YARN_VERSION"
Author
There was a problem hiding this comment.
Setting as 4.x works and will pull the latest stable version of v4. Missed that from the docs earlier. Thanks @ChrisBAshton
The previous image uses an outdated version of Yarn (1.22.22). This commit has now upgraded the package to the latest stable version (4.10.3). We have also updated the cache folder config to follow the new method. See: - https://yarnpkg.com/cli/config/set - https://yarnpkg.com/configuration/yarnrc#cacheFolder
eYinka
force-pushed
the
upgrade-wh-yarn-4
branch
from
October 28, 2025 17:40
120d726 to
4c9f0e2
Compare
eYinka
added a commit
to alphagov/whitehall
that referenced
this pull request
Oct 28, 2025
Following the deprecation of Yarn 1.xx and 2.xx, we have upgraded Whitehall's base image to use Yarn v4. Consequently, flags like `--production` `--frozen-lockfile` have been removed. Associated PR: alphagov/govuk-docker#908 Flags: https://yarnpkg.com/cli/install JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954
MuriloDalRi
approved these changes
Oct 29, 2025
ChrisBAshton
marked this pull request as draft
October 29, 2025 10:13
Contributor
|
Converted to draft. We've decided to hold off until there's support more widely - see issue on Platform Engineering board: alphagov/govuk-infrastructure#3068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous image uses an outdated version of Yarn (1.22.22). This commit has now upgraded the package to the latest stable version (4.10.3). We have also updated the cache folder config to follow the new method. See:
JIRA: https://gov-uk.atlassian.net/browse/WHIT-1954