-
Notifications
You must be signed in to change notification settings - Fork 0
321 split docker image structure #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
geurto
wants to merge
30
commits into
main
Choose a base branch
from
321-split-docker-image-structure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Collaborator
|
I think this branch is not correctly rebased from main. It shows changes in many files you didn't do, like images that are removed in the docs folder and removal of the pyflow folder. Can you fix this, so that there is more overview of what you actually changed? |
Signed-off-by: Jelmer de Wolde <[email protected]>
c7b9671 to
2328932
Compare
…launch.py Signed-off-by: Peter Geurts <[email protected]>
Signed-off-by: Peter Geurts <[email protected]>
… needs cuda/torch; added rcdt_tools Signed-off-by: Peter Geurts <[email protected]>
…oded) properties Signed-off-by: Peter Geurts <[email protected]>
… restart rviz/gazebo without taking down the robot compose Signed-off-by: Peter Geurts <[email protected]>
Signed-off-by: Peter Geurts <[email protected]>
* Add missing docs from ospo checklist, template names still need to be updated Signed-off-by: Rosalie <[email protected]> * Update placeholder values with the correct values, and add some extra text to the README.md Signed-off-by: Rosalie <[email protected]> --------- Signed-off-by: Rosalie <[email protected]>
* Generalize Nav2 tests. Signed-off-by: Jelmer de Wolde <[email protected]> * Create simplified nav2_manager using nav2 commander API. Signed-off-by: Jelmer de Wolde <[email protected]> * Add GPS navigation and extend UI. Signed-off-by: Jelmer de Wolde <[email protected]> * WIP Signed-off-by: Jelmer de Wolde <[email protected]> * Fix tests. Signed-off-by: Jelmer de Wolde <[email protected]> * Switch to using tf2 listener directly. Signed-off-by: Jelmer de Wolde <[email protected]> * Apply feedback. Signed-off-by: Jelmer de Wolde <[email protected]> * Try spin_once function with zero timeouts. Signed-off-by: Jelmer de Wolde <[email protected]> * Apply feedback. Signed-off-by: Jelmer de Wolde <[email protected]> * Apply feedback. Signed-off-by: Jelmer de Wolde <[email protected]> --------- Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Peter Geurts <[email protected]>
…on (and need ros-gz plugins) Signed-off-by: Peter Geurts <[email protected]>
Signed-off-by: Peter Geurts <[email protected]>
Signed-off-by: Peter Geurts <[email protected]>
…compose.py to fix env vars in composes Signed-off-by: Peter Geurts <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
…in Gazebo container. Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restructuring of repository to make it more modular and future-proof. Code and dependencies are split into separate Docker images, with a compose script to create configurations to run.
TO DO:
pyproject.tomldependencies to relevant containers (instead of all dependencies installed in all containers)Fixes: #321
Thins to discuss:
Testing
Explain how you tested your changes.
Documentation
Additional Notes
Any relevant screenshots, logs, or context.