Skip to content

fix and tests for lost precision in unit conversion #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WillemRomijn-werk wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix and tests for lost precision in unit conversion #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96c6c16
fix and tests for lost precision in unit conversion
Apr 9, 2025
884e8c2
Merge branch 'main' of github.com:alliander-opensource/measure into f…
May 6, 2025
8fafdab
added test case
May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion measure/src/main/kotlin/com/alliander/open/measure/Measure.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ data class Measure<U : Units>(val amount: BigDecimal, val units: U) : Comparable
infix fun <A : U> `in`(other: A): BigDecimal =
if (units == other)
amount
else (amount * units.ratio).divide(other.ratio, amount.scale() + units.ratio.precision(), RoundingMode.UP)
else (amount * units.ratio).divide(other.ratio, amount.scale() + other.ratio.precision(), RoundingMode.UP)

operator fun plus(other: Measure<U>): Measure<U> = baseUnits(
units,
Expand Down
14 changes: 14 additions & 0 deletions measure/src/test/kotlin/com/alliander/open/measure/MeasureTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,4 +218,18 @@ class MeasureTest : StringSpec({

result shouldBe expectedResult
}

"Unit conversion uses the correct scale" {
val energyInJoule = 13500000 * joule
val valueInKwh = energyInJoule `in` kiloWattHour
valueInKwh.stripTrailingZeros() shouldBe BigDecimal.valueOf(3.75)

val energyInJoule2 = 3.75 * kiloWattHour
val valueInKwh2 = energyInJoule2 `in` joule
valueInKwh2.stripTrailingZeros() shouldBe BigDecimal.valueOf(1.35E+7)

val powerInW = 1.99E7 * watt
val valueInMw = powerInW `as` megaWatt
valueInMw.amount.stripTrailingZeros() shouldBe BigDecimal.valueOf(19.9)
}
})
Loading