-
Notifications
You must be signed in to change notification settings - Fork 470
Adds retries to checkpointing. #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
7781f3c
8807c53
9e5de5d
72e748f
266de46
19c4c03
6c0273e
4ab6a22
56bbecd
6231dc7
1774d46
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ requires-python = "==3.12.*" | |
| dependencies = [ | ||
| "accelerate>=1.10.1", | ||
| "antlr4-python3-runtime==4.11", | ||
| "backoff>=2.2.1", | ||
| "bitsandbytes>=0.44.1; platform_system != 'Darwin'", | ||
| "datasets>=4.0.0", | ||
|
Comment on lines
7
to
12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The new checkpoint retry logic imports Useful? React with 👍 / 👎. |
||
| "debugpy>=1.8.13", | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
backoff.on_exceptionwith the broadExceptionclass can mask underlying bugs by retrying on non-transient errors likeTypeErrororAttributeError. It's better to specify only the exceptions you expect to be transient, such as I/O or network-related errors. This makes the retry logic more robust and prevents hiding actual code issues.Consider using a more specific set of exceptions. For example, you could catch
IOError,OSError, and Ray-specific task errors. You might need to addimport ray.exceptionsfor this.Example:
@backoff.on_exception(backoff.expo, (IOError, OSError, ray.exceptions.RayTaskError), max_tries=3)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably correct, but I don't know what errors will come up. Instead, I'll keep a list and fix these.