[Playground] Parameters Tab: UI Components only #290#333
Open
juhangil wants to merge 27 commits intoaliencube:mainfrom
Open
[Playground] Parameters Tab: UI Components only #290#333juhangil wants to merge 27 commits intoaliencube:mainfrom
juhangil wants to merge 27 commits intoaliencube:mainfrom
Conversation
juhangil
force-pushed
the
feature/290-parameters-tab-ui
branch
from
8ed39e9 to
bdff959
Compare
justinyoo
requested changes
Oct 7, 2024
Contributor
justinyoo
left a comment
justinyoo
left a comment
There was a problem hiding this comment.
이벤트 버블링 관련해서 코멘트를 남겨뒀습니다.
Comment on lines
9
to
14
| <FluentGrid Spacing="0" AdaptiveRendering="true" Justify="JustifyContent.FlexStart"> | ||
| <FluentGridItem Class="config-grid" xs="12" sm="12" md="4" lg="4" xl="4" xxl="4" Style="border:1px solid lightgrey"> | ||
| <ConfigWindowComponent Id="config-window" OnSystemMessageChanged="SetSystemMessage" @rendermode="InteractiveServer" /> | ||
| </FluentGridItem> | ||
|
|
||
| <FluentGridItem Class="chat-grid" xs="12" sm="12" md="8" lg="8" xl="8" xxl="8" Style="height: 900px;"> | ||
| <FluentGridItem Class="chat-grid" xs="12" sm="12" md="8" lg="8" xl="8" xxl="8" Style="border:1px solid lightgrey"> |
Contributor
There was a problem hiding this comment.
이 스타일은 나중에 최종적으로 다시 원래대로 돌려놓을 건가요, 아니면 쭉 이대로 갈 건가요?
Contributor
Author
There was a problem hiding this comment.
최종적으로는 돌려놓고 작업 도중에는 유지하는게 낫지 않을까 생각합니다
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ParametersTabComponent.razor
Outdated
Show resolved
Hide resolved
| public string? Id { get; set; } | ||
|
|
||
| [Parameter] | ||
| public EventCallback<TValue> ValueChanged { get; set; } |
Contributor
There was a problem hiding this comment.
OnValueChanged로 바꾸는 것이 좋겠습니다.
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ParameterMultiselectComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ParameterMultiselectComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ParameterMultiselectComponent.razor
Outdated
Show resolved
Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ParameterRangeComponent.razor
Outdated
Show resolved
Hide resolved
|
|
||
| <div id="@Id" class="parameter-tab"> | ||
| @* Past Messages Range *@ | ||
| <ParameterRangeComponent Id="range-past-messages" |
Contributor
There was a problem hiding this comment.
이 컴포넌트의 OnValueChanged 이벤트를 바인딩해서 ConfigTabComponent, ConfigWindowComponent 쪽으로 버블업 시켜줘야 합니다. 그렇게 해서 결국 Playground 페이지에서 값을 인식할 수 있어야 합니다.
Contributor
Author
There was a problem hiding this comment.
다른 컴포넌트 값들을 하나로 묶어서 처리하자니 코드가 너무 더러워지는 것 같아서 양방향 바인딩으로 처리해봤습니다
- Add border line on Playground.razor grid item for visualize layout
juhangil
force-pushed
the
feature/290-parameters-tab-ui
branch
from
bdff959 to
fb87a63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description