[Controls] TimelineSlider: Improve slider's behaviour#3094
Open
cbentejac wants to merge 2 commits into
Open
Conversation
Add a right padding on the timeline to prevent the slider from ever going to the extreme side; we always expect the slider to be, at most, a frame away from the far-end of the timeline.
…r marks Prior to this commit, the slider could be in a position that was misaligned with the corresponding marker for that same position.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3094 +/- ##
========================================
Coverage 83.56% 83.56%
========================================
Files 81 81
Lines 10322 10322
========================================
Hits 8626 8626
Misses 1696 1696 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building up on top of #3059, this PR improves two elements of the Sequence Player's timeline slider: