Skip to content

[Controls] TimelineSlider: Improve slider's behaviour#3094

Open
cbentejac wants to merge 2 commits into
developfrom
dev/timelineSliderImprov
Open

[Controls] TimelineSlider: Improve slider's behaviour#3094
cbentejac wants to merge 2 commits into
developfrom
dev/timelineSliderImprov

Conversation

@cbentejac
Copy link
Copy Markdown
Contributor

Description

Building up on top of #3059, this PR improves two elements of the Sequence Player's timeline slider:

  • The slider's position could be misaligned with the frame number markers. For example, there could be a marker for frame n°5, the slider would be set for frame n°5, but the slider would not be visually aligned with the marker for that frame.
  • The last position the slider could reach was the far-end of the timeline, which we do not want. Instead, we want this space to be reserved for a phantom-frame, and the slider to be physically blocked right before reaching this phantom-frame.

cbentejac added 2 commits May 12, 2026 14:57
Add a right padding on the timeline to prevent the slider from ever
going to the extreme side; we always expect the slider to be, at most,
a frame away from the far-end of the timeline.
…r marks

Prior to this commit, the slider could be in a position that was
misaligned with the corresponding marker for that same position.
@cbentejac cbentejac added this to the Meshroom 2026.1.0 milestone May 12, 2026
@cbentejac cbentejac requested a review from fabiencastan May 12, 2026 13:46
@cbentejac cbentejac self-assigned this May 12, 2026
@cbentejac cbentejac added the UI label May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.56%. Comparing base (e270ef5) to head (16a5756).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3094   +/-   ##
========================================
  Coverage    83.56%   83.56%           
========================================
  Files           81       81           
  Lines        10322    10322           
========================================
  Hits          8626     8626           
  Misses        1696     1696           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant