Skip to content

Remove in tree asio deps#466

Merged
ChuanqiXu9 merged 3 commits intoalibaba:mainfrom
c8ef:asio
Mar 28, 2026
Merged

Remove in tree asio deps#466
ChuanqiXu9 merged 3 commits intoalibaba:mainfrom
c8ef:asio

Conversation

@c8ef
Copy link
Copy Markdown
Collaborator

@c8ef c8ef commented Mar 28, 2026

Why

Currently, we rely on the in-tree asio, which makes it difficult to upgrade versions.

What is changing

  • Remove the tree in asio. -> 4241e21
  • Update bazel builds; update demo-example to accommodate new asio changes. -> f23ac9c
  • Update cmake builds. -> e172f66

Example

@c8ef c8ef marked this pull request as ready for review March 28, 2026 05:30
@c8ef c8ef requested review from ChuanqiXu9 and poor-circle March 28, 2026 05:31
@ChuanqiXu9
Copy link
Copy Markdown
Collaborator

I still like in-tree deps as it is only for examples. And many people have some problems with network, so I don't want to change this. If you want to upgrade its version, I think you can upgrade it too. It might not be so hard.

@c8ef
Copy link
Copy Markdown
Collaborator Author

c8ef commented Mar 28, 2026

I still like in-tree deps as it is only for examples. And many people have some problems with network, so I don't want to change this. If you want to upgrade its version, I think you can upgrade it too. It might not be so hard.

I agree with the network conditions, but we have been using this approach for gtest for two years. I simply copied the approach.

FetchContent_Declare(
googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG v1.17.0
GIT_SHALLOW ON
)

If users find it difficult to clone the repository, using asio from the package manager would be a better solution. And the newly added cmake file supports this.

Copy link
Copy Markdown
Collaborator

@ChuanqiXu9 ChuanqiXu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds not bad

@ChuanqiXu9 ChuanqiXu9 merged commit 8c87179 into alibaba:main Mar 28, 2026
16 checks passed
@c8ef c8ef deleted the asio branch April 8, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants