make uthread internal function override cross platform#465
Merged
ChuanqiXu9 merged 2 commits intoalibaba:mainfrom Mar 25, 2026
Merged
make uthread internal function override cross platform#465ChuanqiXu9 merged 2 commits intoalibaba:mainfrom
uthread internal function override cross platform#465ChuanqiXu9 merged 2 commits intoalibaba:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
__attribute__((weak))is not supported by MSVC.What is changing
Replaces weak symbol overriding with a function pointer setter, using the construct-on-first-use idiom to avoid static initialization order issues.
Not sure if going through a function pointer hurts inlining in practice - didn't see any performance regression in the uthread benchmarks though.
Also not sure if depending on the
internalapi is the right call here, happy to hear thoughts on that.Example