Fix [3462] Incorrect method of reading indicator files #3465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
manojks1999
changed the title
Collaborator
|
This code is currently processing an index file. I'm having trouble mapping the issue description to the observed behavior - could you please elaborate on the exact conditions/reproduction steps you're encountering? Additionally, if we remove this line, the while condition would incorrectly compare Index with beginSecond, which is semantically invalid as these represent different dimensional units in our processing pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fixes for #3462
Does this pull request fix one issue?
Fixes #3462
Describe how you did it
Removed line 209 of sentinel-core/src/main/java/com/alibaba/csp/sentinel/node/metric/MetricSearcher.java
Describe how to verify it
Special notes for reviews