Skip to content

task-executor sync alibaba to public#171

Open
fengcone wants to merge 2 commits intoalibaba:mainfrom
fengcone:feature/public-sync-task-executor
Open

task-executor sync alibaba to public#171
fengcone wants to merge 2 commits intoalibaba:mainfrom
fengcone:feature/public-sync-task-executor

Conversation

@fengcone
Copy link
Collaborator

@fengcone fengcone commented Feb 4, 2026

Summary

  • What is changing and why?

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@Pangjiping Pangjiping added the component/k8s For kubernetes runtime label Feb 4, 2026
@jwx0925
Copy link
Collaborator

jwx0925 commented Feb 6, 2026

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d331eae31a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}

func (c *Config) InitKlog() error {
if err := os.MkdirAll(c.LogDir, 0755); err != nil {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid defaulting log directory to unwritable workdir

This change makes startup depend on creating logs/ (InitKlog) and exits immediately on failure, but the default image runs as non-root (USER $USERID) in WORKDIR /workspace (kubernetes/Dockerfile), which is typically root-owned and not writable by UID 65532. In that default deployment path, os.MkdirAll("logs", 0755) fails and main exits, so task-executor will not come up unless operators override --log-dir or change filesystem permissions.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/k8s For kubernetes runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants