Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d331eae31a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| func (c *Config) InitKlog() error { | ||
| if err := os.MkdirAll(c.LogDir, 0755); err != nil { |
There was a problem hiding this comment.
Avoid defaulting log directory to unwritable workdir
This change makes startup depend on creating logs/ (InitKlog) and exits immediately on failure, but the default image runs as non-root (USER $USERID) in WORKDIR /workspace (kubernetes/Dockerfile), which is typically root-owned and not writable by UID 65532. In that default deployment path, os.MkdirAll("logs", 0755) fails and main exits, so task-executor will not come up unless operators override --log-dir or change filesystem permissions.
Useful? React with 👍 / 👎.
Summary
Testing
Breaking Changes
Checklist