feat(volume): add host and pvc volume types to OpenAPI spec #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the OpenSpec definition for host and pvc volume backends as described in OSEP-0003. This includes: - OpenAPI schema definitions for Volume, HostBackend, PVCBackend, AccessMode - Server-side Pydantic models with validation - Comprehensive validator functions for volume configurations - Volume-related error codes - Unit tests for schema models and validators (73 tests) - Auto-generated SDK models The proposal status is updated to 'implementing'. Refs: OSEP-0003
hittyt
requested review from
Generalwin,
Pangjiping,
Spground,
fengcone,
jwx0925,
kevinlynx and
ninan-nn
as code owners
Pangjiping
added
documentation
Add retry mechanism and initialization delay to reduce flaky test failures in multi-language context tests: - Add run_with_retry helper with exponential backoff (max 3 retries) - Add 0.2s delay after context creation for kernel initialization - Apply retry logic to test_06 cross-language execution tests This addresses intermittent failures where execution returns empty results due to kernel not being fully ready.
Improve test stability by catching and retrying on network errors: - Add exception handling for RemoteProtocolError, connection reset, etc. - Add create_context_with_retry helper for context creation - Increase initial retry delay to 2s for better recovery - Add cleanup retry in managed_ctx to handle server disconnects - Detect retryable errors by checking error message keywords This addresses CI failures where the server disconnects mid-request.
Increase sleep from 5ms to 2000ms to allow NetworkPolicy sidecar to fully initialize before testing egress rules. The previous 5ms delay was insufficient for the sidecar to be ready, causing curl to github.com to succeed when it should have been blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the OpenSpec definition for host and pvc volume backends as described in OSEP-0003. This includes:
The proposal status is updated to 'implementing'.
Refs: OSEP-0003
Testing
Breaking Changes
Checklist